Re: [PATCH] ASoC: wm97xx: fix uninitialized regmap pointer problem

From: Arnd Bergmann
Date: Fri Nov 02 2018 - 11:15:53 EST


On 11/2/18, Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Nov 02, 2018 at 12:23:08PM +0100, Arnd Bergmann wrote:

>> static void wm9713_soc_remove(struct snd_soc_component *component)
>> {
>> -#ifdef CONFIG_SND_SOC_AC97_BUS
>> struct wm9713_priv *wm9713 = snd_soc_component_get_drvdata(component);
>>
>> - if (!wm9713->mfd_pdata) {
>> + if (IS_ENABLED(CONFIG_SND_SOC_AC97_BUS)) {
>
> Should this one not also have an && !wm9713->mfd_pdata?

Right, good catch!. I'll send a fixed version in a bit.

Arnd