Re: [PATCH V5 8/8] dt-bindings/misc/pvpanic :add document for pvpanic-mmio

From: Mark Rutland
Date: Thu Nov 01 2018 - 07:46:12 EST


Please fix the spacing in the commit title. It should be formatted:

dt-bindings: misc/pvpanic: add document for pvpanic-mmio

On Thu, Nov 01, 2018 at 11:10:02PM +0800, Peng Hao wrote:
> Add dt-bindings document for "qemu:pvpanic-mmio".
>
> Signed-off-by: Peng Hao <peng.hao2@xxxxxxxxxx>

With the title fixed:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

When sending DT bindings in future, please follow the process in:

Documentation/devicetree/bindings/submitting-patches.txt

... e.g., send the binding before the code using the binding.

Thanks,
Mark.

> ---
> .../devicetree/bindings/misc/pvpanic-mmio.txt | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/pvpanic-mmio.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/pvpanic-mmio.txt b/Documentation/devicetree/bindings/misc/pvpanic-mmio.txt
> new file mode 100644
> index 0000000..985e907
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/pvpanic-mmio.txt
> @@ -0,0 +1,29 @@
> +* QEMU PVPANIC MMIO Configuration bindings
> +
> +QEMU's emulation / virtualization targets provide the following PVPANIC
> +MMIO Configuration interface on the "virt" machine.
> +type:
> +
> +- a read-write, 16-bit wide data register.
> +
> +QEMU exposes the data register to guests as memory mapped registers.
> +
> +Required properties:
> +
> +- compatible: "qemu,pvpanic-mmio".
> +- reg: the MMIO region used by the device.
> + * Bytes 0x0 Write panic event to the reg when guest OS panics.
> + * Bytes 0x1 Reserved.
> +
> +Example:
> +
> +/ {
> + #size-cells = <0x2>;
> + #address-cells = <0x2>;
> +
> + pvpanic-mmio@9060000 {
> + compatible = "qemu,pvpanic-mmio";
> + reg = <0x0 0x9060000 0x0 0x2>;
> + };
> +};
> +
> --
> 1.8.3.1
>