Re: PROPOSAL: Extend inline asm syntax with size spec

From: Peter Zijlstra
Date: Thu Nov 01 2018 - 05:01:41 EST


On Wed, Oct 31, 2018 at 10:20:00PM -0700, Joe Perches wrote:
> On Wed, 2018-10-31 at 13:55 +0100, Peter Zijlstra wrote:
> >
> > Anyway, with the below patch, I get:
> >
> > text data bss dec hex filename
> > 17385183 5064780 1953892 24403855 1745f8f defconfig-build/vmlinux
> > 17385678 5064780 1953892 24404350 174617e defconfig-build/vmlinux
> >
> > Which shows we inline more (look for asm_volatile for the actual
> > changes).
> []
> > scripts/checkpatch.pl | 8 ++---
> > scripts/genksyms/keywords.c | 4 +--
> > scripts/kernel-doc | 4 +--
>
> I believe these should be excluded from the conversions.

Probably, yes. It compiled, which was all I cared about :-)

BTW, if we do that conversion, we should upgrade the checkpatch warn to
an error I suppose.