Re: [PATCH v3 1/5] dt-bindings: phy-qcom-qmp: Fix register underspecification

From: Rob Herring
Date: Tue Oct 23 2018 - 11:35:22 EST


On Mon, Oct 22, 2018 at 01:50:58PM -0700, Evan Green wrote:
> Add register regions for the second lane of dual-lane nodes.
> This additional specification is needed so that the driver can stop
> reaching beyond the tx and rx register allocations to get at the
> second lane registers in a dual-lane PHY.
>
> While in there, document #clock-cells as optional for PHYs that don't
> provide a pipe clock. Also, document the pcs_misc register region, which
> was being quietly supplied and used.
>
> Signed-off-by: Evan Green <evgreen@xxxxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Added dt bindings change, corresponding driver fixup, and USB PHY fixup

Please see my reply on v2.

>
> .../devicetree/bindings/phy/qcom-qmp-phy.txt | 73 +++++++++++++++++++---
> 1 file changed, 65 insertions(+), 8 deletions(-)