Re: [PATCH v2 1/3] ARM: socfpga: Clean unused functions

From: ClÃment PÃron
Date: Tue Oct 23 2018 - 04:47:20 EST


Hi Dinh / Russell,

Could you have a look at these patchs please ?

Thanks,
Clement

On Tue, 9 Oct 2018 at 13:20, ClÃment PÃron <peron.clem@xxxxxxxxx> wrote:
>
> These functions are unused externally, removed them and declare
> the one used locally as static.
>
> Signed-off-by: ClÃment PÃron <peron.clem@xxxxxxxxx>
> ---
> arch/arm/mach-socfpga/core.h | 2 --
> arch/arm/mach-socfpga/socfpga.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-socfpga/core.h b/arch/arm/mach-socfpga/core.h
> index 65e1817d8afe..92cae0a9213f 100644
> --- a/arch/arm/mach-socfpga/core.h
> +++ b/arch/arm/mach-socfpga/core.h
> @@ -34,8 +34,6 @@
>
> #define RSTMGR_MPUMODRST_CPU1 0x2 /* CPU1 Reset */
>
> -extern void socfpga_init_clocks(void);
> -extern void socfpga_sysmgr_init(void);
> void socfpga_init_l2_ecc(void);
> void socfpga_init_ocram_ecc(void);
> void socfpga_init_arria10_l2_ecc(void);
> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
> index dde14f7bf2c3..5fb6f79059a8 100644
> --- a/arch/arm/mach-socfpga/socfpga.c
> +++ b/arch/arm/mach-socfpga/socfpga.c
> @@ -32,7 +32,7 @@ void __iomem *rst_manager_base_addr;
> void __iomem *sdr_ctl_base_addr;
> unsigned long socfpga_cpu1start_addr;
>
> -void __init socfpga_sysmgr_init(void)
> +static void __init socfpga_sysmgr_init(void)
> {
> struct device_node *np;
>
> --
> 2.17.1
>