Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning.

From: Andy Lutomirski
Date: Mon Oct 22 2018 - 22:13:59 EST




> On Oct 22, 2018, at 6:10 PM, Leonardo BrÃs <leobras.c@xxxxxxxxx> wrote:
>
> Renames the char variable to avoid shadowing a variable previously
> declared on this function.

How about âThe go32() and go64() functions has an argument and a local variable called ânameâ. Rename both to clarify the code and to fix a warning with -Wshadow.â

Other than that, Acked-by: Andy Lutomirski <luto@xxxxxxxxxx>

Ingo or Thomas, it probably makes sense to just apply this to tip:x86/vdso, since itâs an improvement regardless of the fate of the rest of the series.