Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1

From: Rob Herring
Date: Wed Oct 17 2018 - 11:09:35 EST


On Tue, Oct 16, 2018 at 10:44:52AM +0200, Gustavo A. R. Silva wrote:
> Hi,
>
> On 10/9/18 9:27 AM, Quentin Schulz wrote:
> > Hi Gustavo,
> >
> > On Tue, Oct 09, 2018 at 12:21:36AM +0200, Gustavo A. R. Silva wrote:
> >> SERDES_MAX is a valid value to index ctrl->phys in
> >> drivers/phy/mscc/phy-ocelot-serdes.c. But, currently,
> >> there is an out-of-bounds bug in the mentioned driver
> >> when reading from ctrl->phys, because the size of
> >> array ctrl->phys is SERDES_MAX.
> >>
> >> Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1.
> >>
> >> Notice that this is the first part of the solution to
> >> the out-of-bounds bug mentioned above. Although this
> >> change is not dependent on any other one.
> >>
> >
> > Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxx>
> >
>
> Friendly ping. Who can you take this?

Applied. No need (nor benefit) to ping me. You can check the status of
DT patches on patchwork[1]. If it is there and in the "New" state, it is
in my queue.

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/