Re: [PATCH -next] advansys: use correct srb_tag in adv_isr_callback

From: YueHaibing
Date: Wed Oct 17 2018 - 08:04:00 EST



On 2018/10/17 9:34, Martin K. Petersen wrote:
>
> Hi Yue Haibing,
>
>> srb_tag = le32_to_cpu(scsiqp->srb_tag);
>> - scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
>> + scp = scsi_host_find_tag(boardp->shost, srb_tag);
>
> Maybe I'm missing something, but I don't see where in the code
> scsiqp->srb_tag is being converted to le32. srb_tag is beyond the memory
> accessed by the controller and thus wouldn't need to be little endian.

Thanks for comment this.

So 'srb_tag' can been removed.

>