Re: [PATCH v3 1/1] serial: imx - Add dma buffer confugration via sysfs

From: Fabien Lahoudere
Date: Wed Oct 17 2018 - 04:20:32 EST


Hi Greg,

On Mon, 2018-10-15 at 16:01 +0200, Greg KH wrote:
> On Thu, Oct 11, 2018 at 11:25:03AM +0200, Fabien Lahoudere wrote:
> > In order to optimize serial communication on imx53 and imx6, we may
> > need to tweak DMA period and buffer length per period.
>
> Why can you not just automatically determine this information?ÂÂWhat is
> userspace going to know that the kernel can not just learn now?
>
> Having tunables is nice, but it is even better to not need them at all.

I agree that it is better to let the kernel do the configuration.
However in our case we use several serial communication for different device
and one of them need to tweak that configuration to get small data with a better
period. However having this parameter for all serial port implies a bigger number
of interrupts for others too.

>
> thanks,
>
> greg k-h
--
Fabien