Re: [RFC v1 12/31] checkpatch: added support for struct MOCK(foo) syntax

[Joe Perches]

On Tue, 2018-10-16 at 16:51 -0700, Brendan Higgins wrote:
> This adds struct MOCK(foo) as a NonptrType so that it is recognized
> correctly in declarations.

I think this commit message is lacking context.


> Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
> ---
>  scripts/checkpatch.pl | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 447857ffaf6be..9806f190796de 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -745,6 +745,10 @@ sub build_types {
>  			(?:
>  				(?:typeof|__typeof__)\s*\([^\)]*\)|
>  				(?:$typeTypedefs\b)|
> +				# Matching a \b breaks struct MOCK(foo) syntax,
> +				# so we need to have it not lumped in with the
> +				# types in @typeList.
> +				(?:struct\s+MOCK\($Ident\))|
>  				(?:${all}\b)
>  			)
>  			(?:\s+$Modifier|\s+const)*