Re: [RFC][PATCH] x86: ptrace: Add function argument access API

From: Steven Rostedt
Date: Tue Oct 16 2018 - 14:59:52 EST


On Mon, 15 Oct 2018 23:56:46 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> This patch looks good to me.
> But if the concern is real, all regs_get_kernel_stack_nth() user must move
> onto _safe() version, at least all tracers code.

Doing a git grep on regs_get_kernel_stack_nth(), I think you are right.
I'll resend and make the _nth() function just the _safe() function. No
need to do it without the probe_kernel_read() call.

>
> Reviewed-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thanks,

-- Steve

>
>