Re: [PATCH] tools/power/cpupower: fix compilation with STATIC=true

From: Shuah Khan
Date: Tue Oct 16 2018 - 10:29:04 EST


On 10/16/2018 05:39 AM, Thomas Renninger wrote:
> On Tuesday, October 16, 2018 10:56:26 AM CEST Konstantin Khlebnikov wrote:
>> Rename duplicate sysfs_read_file into cpupower_read_sysfs and fix linking.
>>
>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
>
> Acked-by: Thomas Renninger <trenn@xxxxxxx>
>
> Thanks!
>
>> - $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/sysfs.o
>> + $(OUTPUT)../lib/cpufreq.o $(OUTPUT)../lib/cpupower.o
>
> I also looked at this and would only have fixed half of it (overseeing above
> old leftover from cpupower lib introduction).
> I guess, this patch from Konstantin is better and the correct solution.
>

Thank you both. I will get this into 4.20-rc1 or rc2 depending on how timing
works.

I think this applies to stable as well.

thanks,
-- Shuah