Re: [PATCH 4/5] locking/lockdep: Make class->ops a percpu counter

From: kbuild test robot
Date: Fri Sep 28 2018 - 16:26:15 EST


Hi Waiman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/locking/core]
[also build test ERROR on v4.19-rc5 next-20180928]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Waiman-Long/locking-lockdep-Remove-add_chain_cache_classes/20180929-031820
config: i386-randconfig-s2-201838 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

kernel/locking/lockdep_proc.c: In function 'l_show':
>> kernel/locking/lockdep_proc.c:71:34: error: 'struct lock_class' has no member named 'ops'; did you mean 'pops'?
seq_printf(m, " OPS:%8ld", class->ops);
^~

vim +71 kernel/locking/lockdep_proc.c

068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 57
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 58 static int l_show(struct seq_file *m, void *v)
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 59 {
8109e1de8 kernel/lockdep_proc.c Li Zefan 2009-08-17 60 struct lock_class *class = list_entry(v, struct lock_class, lock_entry);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 61 struct lock_list *entry;
f510b233c kernel/lockdep_proc.c Peter Zijlstra 2009-01-22 62 char usage[LOCK_USAGE_CHARS];
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 63
8109e1de8 kernel/lockdep_proc.c Li Zefan 2009-08-17 64 if (v == &all_lock_classes) {
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 65 seq_printf(m, "all lock classes:\n");
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 66 return 0;
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 67 }
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 68
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 69 seq_printf(m, "%p", class->key);
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 70 #ifdef CONFIG_DEBUG_LOCKDEP
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 @71 seq_printf(m, " OPS:%8ld", class->ops);
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 72 #endif
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 73 #ifdef CONFIG_PROVE_LOCKING
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 74 seq_printf(m, " FD:%5ld", lockdep_count_forward_deps(class));
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 75 seq_printf(m, " BD:%5ld", lockdep_count_backward_deps(class));
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 76 #endif
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 77
f510b233c kernel/lockdep_proc.c Peter Zijlstra 2009-01-22 78 get_usage_chars(class, usage);
f510b233c kernel/lockdep_proc.c Peter Zijlstra 2009-01-22 79 seq_printf(m, " %s", usage);
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 80
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 81 seq_printf(m, ": ");
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 82 print_name(m, class);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 83 seq_puts(m, "\n");
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 84
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 85 list_for_each_entry(entry, &class->locks_after, entry) {
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 86 if (entry->distance == 1) {
2429e4ee7 kernel/lockdep_proc.c Huang, Ying 2008-06-13 87 seq_printf(m, " -> [%p] ", entry->class->key);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 88 print_name(m, entry->class);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 89 seq_puts(m, "\n");
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 90 }
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 91 }
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 92 seq_puts(m, "\n");
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 93
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 94 return 0;
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 95 }
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 96

:::::: The code at line 71 was first introduced by commit
:::::: a8f24a3978c5f82419e1c90dc90460731204f46f [PATCH] lockdep: procfs

:::::: TO: Ingo Molnar <mingo@xxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip