Re: [PATCH net-next 00/10] Cleanups, minor additions & fixes for HNS3 driver

From: Eric Dumazet
Date: Fri Sep 28 2018 - 14:56:17 EST




On 09/28/2018 10:38 AM, David Miller wrote:
> From: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Date: Wed, 26 Sep 2018 19:28:30 +0100
>
>> This patch-set contains cleans-ups, minor changes and fixes to the HNS3 driver.
>
> Series applied, thank you.
>

Something seems wrong

# git grep -n HNS3_SELF_TEST_TYPE_NUM
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278: int st_param[HNS3_SELF_TEST_TYPE_NUM][2];
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:316: for (i = 0; i < HNS3_SELF_TEST_TYPE_NUM; i++) {

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c: In function 'hns3_self_test':
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: error: 'HNS3_SELF_TEST_TYPE_NUM' undeclared (first use in this function)
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:15: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:278:6: error: unused variable 'st_param' [-Werror=unused-variable]