Re: [RFC workqueue/driver-core PATCH 5/5] nvdimm: Schedule device registration on node local to the device

From: Dan Williams
Date: Fri Sep 28 2018 - 13:46:36 EST


On Wed, Sep 26, 2018 at 2:52 PM Alexander Duyck
<alexander.h.duyck@xxxxxxxxxxxxxxx> wrote:
>
> This patch is meant to force the device registration for nvdimm devices to
> be closer to the actual device. This is achieved by using either the NUMA
> node ID of the region, or of the parent. By doing this we can have
> everything above the region based on the region, and everything below the
> region based on the nvdimm bus.
>
> By guaranteeing NUMA locality I see an improvement of as high as 25% for
> per-node init of a system with 12TB of persistent memory.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx>

Looks good to me. This does have a dependency on the current contents
of libnvdimm development tree.