Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

[Sinan Kaya]

On 9/28/2018 6:24 AM, poza@xxxxxxxxxxxxxx wrote:
> 1)ÂDoesÂthatÂseemÂlikeÂtheÂrightÂplace?

IMO, I think best is to call after driver callback in PCI core.
A driver specific action can cause some of these errors.
We don't want to return with outstanding errors.

> 2)ÂIÂguessÂallÂweÂneedÂnowÂwouldÂbeÂtoÂremoveÂtheÂcallsÂfromÂthe
>  ÂÂÂdrivers?

yes

> 3)ÂIfÂweÂremoveÂallÂtheÂcallsÂfromÂtheÂdrivers,ÂweÂshouldÂremoveÂthe
>  ÂÂÂdeclarationÂfromÂinclude/linux/aer.h,Âtoo.

makes sense

> IÂcanÂtakeÂcareÂofÂtheseÂupdatesÂifÂweÂagreeÂthey'reÂtheÂrightÂthing
> toÂdo.