RE: [PATCH v3] usb: hub: try old enumeration scheme first for high speed devices

From: Zengtao (B)
Date: Thu Sep 27 2018 - 23:39:11 EST


Hi greg:

Sorry for the late response, I have applied the tags and resend, please receive it and check

Thx
Zengtao

>-----Original Message-----
>From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
>Sent: Thursday, September 20, 2018 6:38 PM
>To: Roger Quadros <rogerq@xxxxxx>
>Cc: Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; stern@xxxxxxxxxxxxxxxxxxx;
>mathias.nyman@xxxxxxxxxxxxxxx; drinkcat@xxxxxxxxxxxx;
>felipe.balbi@xxxxxxxxxxxxxxx; drake@xxxxxxxxxxxx;
>ravisadineni@xxxxxxxxxxxx; joe@xxxxxxxxxxx; Jonathan Corbet
><corbet@xxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Ingo Molnar
><mingo@xxxxxxxxxx>; Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>;
>Marc Zyngier <marc.zyngier@xxxxxxx>; Kai-Heng Feng
><kai.heng.feng@xxxxxxxxxxxxx>; Thymo van Beers
><thymovanbeers@xxxxxxxxx>; Frederic Weisbecker
><frederic@xxxxxxxxxx>; Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>;
>David Rientjes <rientjes@xxxxxxxxxx>; Mike Looijmans
><mike.looijmans@xxxxxxxx>; linux-doc@xxxxxxxxxxxxxxx;
>linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v3] usb: hub: try old enumeration scheme first for
>high speed devices
>
>On Mon, Aug 20, 2018 at 09:55:49AM +0300, Roger Quadros wrote:
>> On 20/08/18 13:04, Zeng Tao wrote:
>> > The new scheme is required just to support legacy low and full-speed
>> > devices. For high speed devices, it will slower the enumeration speed.
>> > So in this patch we try the "old" enumeration scheme first for high
>> > speed devices, and this is what Windows does since Windows 8.
>> >
>> > Signed-off-by: Zeng Tao <prime.zeng@xxxxxxxxxxxxx>
>>
>> You need to add Alan's Ack here. I don't think you need to resend
>though.
>>
>> Reviewed-by: Roger Quadros <rogerq@xxxxxx>
>
>Please resend, I need his ack here :)
>
>thanks,
>
>greg k-h