Re: [PATCH v2 06/21] platform: goldfish: pipe: Add DMA support to goldfish pipe

From: Greg KH
Date: Thu Sep 27 2018 - 01:19:31 EST


On Wed, Sep 26, 2018 at 04:02:19PM -0700, rkir@xxxxxxxxxx wrote:
> From: Roman Kiryanov <rkir@xxxxxxxxxx>
>
> Goldfish DMA is an extension to the pipe device and is designed
> to facilitate high-speed RAM->RAM transfers from guest to host.
>
> See uapi/linux/goldfish/goldfish_dma.h for more details.
>
> Signed-off-by: Roman Kiryanov <rkir@xxxxxxxxxx>
> Signed-off-by: Lingfeng Yang <lfy@xxxxxxxxxx>
> ---
> Changes in v2:
> - Got sign-off from Lingfeng Yang.
> - Removed the license boilerplate from goldfish_dma.h.
> - Rebased.

I don't understand this series. Please start over with 01/XX as your
other patches were all merged.

And I still think you need a better justification for this, given the
many other ways the kernel already has for this feature...

thanks,

greg k-h