Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

[dkota]

On 2018-09-26 01:24, Doug Anderson wrote:
> Hi,
>
> On Tue, Sep 25, 2018 at 12:36 PM <dkota@xxxxxxxxxxxxxx> wrote:
> > >> +       unsigned int cur_speed_hz;
> > >
> > > unsigned long for Hz? The clk framework uses that type.
> >
> > cur_speed_hz stores the speed value requested as part of transfer (not
> > the resultant or rounded off frequency got from clk framework. It is 
> > u32
> > type, i will change cur_speed_hz to u32 type instead of unsigned long.
> > Code snippet:
> >          mas->cur_speed_hz = xfer->speed_hz;
>
> Change it to "unsigned long" anyway to match the clock framework.  In
> theory maybe the "xfer" structure will be updated eventually.
Ok. WIll update it
>


> > Is it possible for all three conditions above to happen in one
> > interrupt? I ask because 'ret' is overwritten and so what may have 
> > been
> > IRQ_HANDLED may become IRQ_NONE which will lead to confusion in the 
> > irq
> > layer. Maybe the handle tx/rx functions can return a bool, that gets
> > orred together each time so that we know if something handled an
> > interrupt?
> Will check it again by running fullduplex transfer and update.
Added the changes in V5 to ensure return value doesn't get overwritten.

--Dilip