Re: [PATCH] crypto: caam/qi2 - add CONFIG_NETDEVICES dependency

[Horia Geanta]

On 9/26/2018 4:01 PM, Arnd Bergmann wrote:
> This driver implements a (part of a) network driver, and fails to
> build if we have turned off networking support:
> 
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
> caamalg_qi2.c:(.text+0x577c): undefined reference to `napi_schedule_prep'
> caamalg_qi2.c:(.text+0x578c): undefined reference to `__napi_schedule_irqoff'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
> caamalg_qi2.c:(.text+0x59b8): undefined reference to `napi_complete_done'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_remove':
> caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to `napi_disable'
> caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to `netif_napi_del'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
> caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'
> 
> From what I can tell, CONFIG_NETDEVICES is the correct dependency here,
> and adding it fixes the randconfig failures.
> 
> Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Acked-by: Horia Geantă <horia.geanta@xxxxxxx>

Thanks,
Horia