RE: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes

From: Woojung.Huh
Date: Tue Sep 25 2018 - 13:19:21 EST


Hi Florian,

> @@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev,
> if (wol->wolopts & WAKE_ARP)
> pdata->wol |= WAKE_ARP;
>
> + if (pdata->wol == 0)
> + return -EINVAL;
> +
It will make function return when disabling WOL.
Is there other place handling this scenario?

> device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);
>
> phy_ethtool_set_wol(netdev->phydev, wol);


Thanks.
Woojung