Re: [PATCH 2/3] powerpc: Add system call table generation support

From: Michael Ellerman
Date: Tue Sep 25 2018 - 08:25:10 EST


Arnd Bergmann <arnd@xxxxxxxx> writes:
> On Tue, Sep 25, 2018 at 2:48 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>> Arnd Bergmann <arnd@xxxxxxxx> writes:
>> > On Tue, Sep 18, 2018 at 2:15 PM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
>> >> On 14 September 2018 at 15:31, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>> >> > On Fri, Sep 14, 2018 at 10:33 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
>> >
>> > But all three existing architectures (x86, s390 and arm) already
>> > have the capability to parse the table and generate different output
>> > from that.
>>
>> Yeah, we want that on powerpc too.
>>
>> If the script needs to be more complex that's fine, if it can't be
>> shared across arches that's fine, the main thing for me is that wiring
>> up a syscall can be done by adding a single line in a single file.
>
> Yes, that's definitely the idea, we want to make it easier for everyone.
> We need at least a special case for mips, which needs three separate
> input files (the tables are completely different) to generate four versions
> of the output, plus a future extension to use the generic table for their
> new one.
>
> For powerpc, I'm hoping that both the table format and script can be
> completely generic and not need a special case that is different
> from the others, but if we need some extra magic to handle the SPU
> syscalls, we can still do that with a private script.

Sounds good.

cheers