Re: [PATCH v5 2/5] drm/dp: fix link probing for devices supporting DP 1.4+

From: Heiko Stuebner
Date: Tue Sep 25 2018 - 07:19:08 EST


Hi Damian,

Am Dienstag, 25. September 2018, 11:13:32 CEST schrieb Damian Kos:
> From: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx>
>
> DP 1.4 introduced a DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit in
> DP_TRAINING_AUX_RD_INTERVAL register. If set, DPCD registers from
> DP_DPCD_REV to DP_ADAPTER_CAP should be retrieved starting from
> DP_DPCD_REV_EXTENDED. All registers are copied except DP_DPCD_REV,
> DP_MAX_LINK_RATE and DP_DOWNSTREAMPORT_PRESENT which represent the
> "true capabilities" of DPRX device.
>
> Original DP_DPCD_REV, DP_MAX_LINK_RATE and DP_DOWNSTREAMPORT_PRESENT
> might falsely return lower capabilities to "avoid interoperability
> issues with some of the existing DP Source devices that malfunction
> when they discover the higher capabilities within those three
> registers.".
>
> Before DP 1.4, DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT bit was reserved
> and read 0 so it's safe to check against it even if DP revision is
> <1.4
>
> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Damian Kos <dkos@xxxxxxxxxxx>

in v4 you received a
Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>
for this patch. If a patch is largely unchanged from one version to another
please add these previously received tags to the commit message.
This prevents people from reviewing needlessly stuff twice ;-) .

So the above should read

----- 8< -----
Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Damian Kos <dkos@xxxxxxxxxxx>
Reviewed-by: Manasi Navare <manasi.d.navare@xxxxxxxxx>
----- 8< -----


Heiko