Re: [PATCH] gpio: mockup: use device properties instead of platform_data

From: Linus Walleij
Date: Tue Sep 25 2018 - 04:53:46 EST


On Mon, Sep 24, 2018 at 9:35 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> niedz., 23 wrz 2018 o 13:17 Bartosz Golaszewski <brgl@xxxxxxxx> napisaÅ(a):
> >
> > Some users want to introduce device tree support to the mockup driver.
> > Let's make it easier by switching to using generic device properties.
> > The driver stays compatible with previous use cases and after this
> > conversion there'll be no need to change the way probing of mockup
> > GPIO chips works.
> >
> > Tested with libgpiod test suite.
> >
> > Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
(...)
> Linus, I just noticed that we either need to drop the check for
> -ENOENT or add an else that returns on any other error. I'll need to
> send a v2

OK business as usual.

> but I'll let you first tell me if you like the general idea.

I don't know, I'm a bit ignorant about the idea, scope and
ambition with device properties.

In my book this relates to the fwnode concept, but maybe
I'm wrong?

Mika, please fill us in here. The device properties in gpiolib
came in the patch
"gpio: Rework of_gpiochip_set_names() to use device property accessors"

Yours,
Linus Walleij