Re: [PATCH v10 12/26] s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl

[Tony Krowiak]

On 09/24/2018 07:43 AM, Cornelia Huck wrote:
> On Wed, 12 Sep 2018 15:43:02 -0400
> Tony Krowiak <akrowiak@xxxxxxxxxxxxxxxxxx> wrote:
>
> > From: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
> >
> > Introduces ioctl access to the VFIO AP Matrix device driver
> > by implementing the VFIO_DEVICE_GET_INFO ioctl. This ioctl
> > provides the VFIO AP Matrix device driver information to the
> > guest machine.
>
> What about the following?
>
> "Add support for the VFIO_DEVICE_GET_INFO ioctl to the VFIO AP Matrix
> device driver. This is a minimal implementation, as vfio-ap does not
> use I/O regions."

Sounds good, I'll change it.

> > Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
> > Reviewed-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
> > Acked-by: Halil Pasic <pasic@xxxxxxxxxxxxx>
> > Tested-by: Michael Mueller <mimu@xxxxxxxxxxxxx>
> > Tested-by: Farhan Ali <alifm@xxxxxxxxxxxxx>
> > Tested-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>
> > Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > ---
> >   drivers/s390/crypto/vfio_ap_ops.c |   38 +++++++++++++++++++++++++++++++++++++
> >   include/uapi/linux/vfio.h         |    1 +
> >   2 files changed, 39 insertions(+), 0 deletions(-)
>
> Anyway,
>
> Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>