Re: [PATCH V4 00/27] C-SKY(csky) Linux Kernel Port

[Arnd Bergmann]

On Mon, Sep 24, 2018 at 9:21 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Arnd,
>
> On Fri, Sep 21, 2018 at 7:19 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > On Thu, Sep 20, 2018 at 10:52 AM Palmer Dabbelt <palmer@xxxxxxxxxx> wrote:
> > > On Fri, 14 Sep 2018 07:37:20 PDT (-0700), ren_guo@xxxxxxxxx wrote:
> > > > On Wed, Sep 12, 2018 at 04:30:36PM +0200, Arnd Bergmann wrote:
> > > >> On Wed, Sep 12, 2018 at 3:25 PM Guo Ren <ren_guo@xxxxxxxxx> wrote:
> > My plan was to get that all into 4.20, and then have a conversation about the
> > actual syscall table changes in 4.21. If we need it for both csky and rv32,
> > we might just change the generic syscall table that way in 4.21 without
> > changing all the other ones along with them. I don't want to drag things out
> > over too many merge windows though, and my plan was to do all architectures
> > together to simplify the version checks in the libc code to only have to check
> > for a single version.
>
> What happens with the version checks if it is backported to stable?

They end up as dead code.

The way these version checks are done in glibc, we always try the new
interface first before falling back to the old version, but don't check the
kernel version at runtime.

The compile-time check optimizes out the fallback if glibc is built for
a recent-enough minimum kernel version that is guaranteed to have
the new version.

      Arnd