Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager

From: Jarkko Sakkinen
Date: Sun Sep 16 2018 - 07:43:19 EST


On Tue, Sep 11, 2018 at 08:04:39AM -0700, Sean Christopherson wrote:
> > +static void sgx_reclaim_pages(void)
> > +{
> > + struct sgx_epc_page *chunk[SGX_NR_TO_SCAN + 1];
>
> The array size should simply be SGX_NR_TO_SCAN.  The +1 is a remnant
> from the previous version that bounded the for-loops with "!chunk[i]"
> check instead of "i < j".  No functional issue, essentially just an
> unused variable.

Thanks, yep, it is cruft.

/Jarkko