Re: [PATCH 3/6] selinux: convert to kvmalloc

From: Kent Overstreet
Date: Fri Sep 07 2018 - 13:50:27 EST


On Sat, Sep 08, 2018 at 02:08:03AM +0900, Tetsuo Handa wrote:
> On 2018/09/08 1:56, Kent Overstreet wrote:
> > @@ -329,8 +328,7 @@ int avtab_alloc(struct avtab *h, u32 nrules)
> > nslot = MAX_AVTAB_HASH_BUCKETS;
> > mask = nslot - 1;
> >
> > - h->htable = flex_array_alloc(sizeof(struct avtab_node *), nslot,
> > - GFP_KERNEL | __GFP_ZERO);
> > + h->htable = kvmalloc_array(nslot, sizeof(void *), GFP_KERNEL);
> > if (!h->htable)
> > return -ENOMEM;
> >
>
> kvmalloc_array() does not imply __GFP_ZERO.

Thanks, fixed