Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet

From: Jakub Kicinski
Date: Fri Sep 07 2018 - 12:36:48 EST


On Fri, 7 Sep 2018 09:21:17 -0700, jun qian wrote:
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <hangdianqj@xxxxxxx>

FWIW you should put spaces after the colons. It's generally a good
practice to look at the prefix previous authors used for a given piece
of code with

git log -- $file_path

This would be a better subject:

nfp: replace spin_lock_bh with spin_lock in tasklet callback