Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free

[Rik van Riel]

On Fri, 2018-09-07 at 14:44 +0100, Will Deacon wrote:
> On Thu, Sep 06, 2018 at 04:29:59PM -0400, Rik van Riel wrote:
> > On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote:
> > > There is no need to call this from tlb_flush_mmu_tlbonly, it
> > > logically belongs with tlb_flush_mmu_free. This allows some
> > > code consolidation with a subsequent fix.
> > > 
> > > Signed-off-by: Nicholas Piggin <npiggin@xxxxxxxxx>
> > 
> > Reviewed-by: Rik van Riel <riel@xxxxxxxxxxx>
> > 
> > This patch also fixes an infinite recursion bug
> > with CONFIG_HAVE_RCU_TABLE_FREE enabled, which
> > has this call trace:
> > 
> > tlb_table_flush
> >   -> tlb_table_invalidate
> >      -> tlb_flush_mmu_tlbonly
> >         -> tlb_table_flush
> >            -> ... (infinite recursion)
> > 
> > This should probably be applied sooner rather than
> > later.
> 
> It's already in mainline with a cc stable afaict.

Sure enough, it is.

I guess I have too many kernel trees on this
system, and was looking at the wrong one somehow.

-- 
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part