Re: linux-next: build warning after merge of the vfs tree

From: David Howells
Date: Fri Sep 07 2018 - 04:57:55 EST


Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> After merging the net-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> security/selinux/hooks.c:2835:12: warning: 'selinux_sb_remount' defined but not used [-Wunused-function]
> static int selinux_sb_remount(struct super_block *sb, void *data, size_t data_size)
> ^~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> dfcf373eab92 ("vfs: Remove unused code after filesystem context changes")

Sorry, I forgot to remove the function. It's no longer used, with the checks
being done in selinux_validate_for_sb_reconfigure() now, called indirectly
from the ->fs_context_validate() hook.

David