Re: [PATCH 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()

From: Doug Anderson
Date: Thu Sep 06 2018 - 12:33:34 EST


Hi,

On Wed, Sep 5, 2018 at 4:37 PM, Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>> int geni_se_clk_tbl_get(struct geni_se *se, unsigned long **tbl)
>> {
>> - unsigned long freq = 0;
>> + long freq = 0;
>
> nit: Since you are already touching this you could also remove the
> pointless initialization, 'freq' is always assigned before it is used.

Done.

-Doug