Re: [PATCH V3 09/26] csky: VDSO and rt_sigreturn

From: Arnd Bergmann
Date: Thu Sep 06 2018 - 10:03:01 EST


On Wed, Sep 5, 2018 at 2:08 PM Guo Ren <ren_guo@xxxxxxxxx> wrote:

> +
> + /*
> + * __NR_rt_sigreturn must be 173
> + * Because gcc/config/csky/linux-unwind.h use hard code to parse rt_sigframe.
> + */
> + err = setup_vdso_page(vdso->rt_signal_retcode);
> + if (err) panic("Cannot set signal return code, err: %x.", err);

__NR_rt_sigreturn is 139

I think you need to update the comment, and probably check your gcc sources
to ensure it still does the right thing.

Arnd