Re: [PATCH] gpio: ep93xx: fix incorrect array element size check

From: Linus Walleij
Date: Thu Sep 06 2018 - 08:44:16 EST


On Thu, Sep 6, 2018 at 1:58 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently the while loop checks for the end of the array using
> the size of egp->gc rather that the number of elements in the array,
> so fix this. Also, perform the array size check first as stylistically
> it is always good to bounds check on an array first before referencing
> the array (in this case, we're just computing the address of an
> element in an array so this is a moot point).
>
> Fixes: fd935fc421e7 ("gpio: ep93xx: Do not pingpong irq numbers")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Oh that was really neat code! Thanks a lot.

Patch applied.

Yours,
Linus Walleij