Re: [PATCH v2 4/6] drm: fix drm_mode_addfb() on big endian machines.

From: Gerd Hoffmann
Date: Thu Sep 06 2018 - 03:18:23 EST


Hi,

> > + bool quirk_addfb_prefer_host_byte_order;
>
> I wonder whether we should reject addFB2 on big endian hosts if this isn't
> set. Otherwise we need addfb3, aka will never be able to fix this. Anyway,
> that might be good work for a follow-up ...

Sounds sensible, I'll send a patch.

> Up to this patch series (with the kerneldoc fixed):
>
> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Fixed, patches 1-4 pushed.

Any takers for 5+6 review? Dave?

thanks,
Gerd