Re: [PATCH v3 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings

From: Stephen Boyd
Date: Wed Sep 05 2018 - 21:53:50 EST


Quoting Taniya Das (2018-09-05 11:26:36)
>
> On 8/28/2018 2:44 AM, Stephen Boyd wrote:
> > Quoting Taniya Das (2018-08-03 05:21:13)
>
> >>
> >> Example:
> >> clock-controller@900000 {
> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt b/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
> >> new file mode 100644
> >> index 0000000..062e413
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/clock/qcom,lpasscc.txt
> >> @@ -0,0 +1,33 @@
> >> +Qualcomm LPASS Clock Controller Binding
> >> +-----------------------------------------------
> >> +
> >> +Required properties :
> >> +- compatible : shall contain "qcom,sdm845-lpasscc"
> >> +- #clock-cells : from common clock binding, shall contain 1.
> >> +- reg : shall contain base register address and size,
> >> + in the order
> >> + Index-0 maps to LPASS_CC register region
> >> + Index-1 maps to LPASS_QDSP6SS register region
> >> +- qcom,lpass-protected : Boolean property to indicate to GCC clock controller
> >> + for the lpass GCC clocks.
> >
> > Why is this here?
> >
>
> Yes, I kept it to make sure it is marked in GCC clock driver too. May be
> should remove it.
>

It isn't a property of the LPASS clock controller though so I don't see
why it is here.