Re: [PATCH V3 21/26] dt-bindings: interrupt-controller: C-SKY APB intc

From: Rob Herring
Date: Wed Sep 05 2018 - 20:43:33 EST


On Wed, Sep 5, 2018 at 7:10 AM Guo Ren <ren_guo@xxxxxxxxx> wrote:
>
> Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx>
> ---
> .../interrupt-controller/csky,apb-intc.txt | 45 ++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> new file mode 100644
> index 0000000..faa482c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,apb-intc.txt
> @@ -0,0 +1,45 @@
> +==============================
> +C-SKY APB Interrupt Controller
> +==============================
> +
> +C-SKY APB Interrupt Controller is a simple soc interrupt controller
> +on the apb bus and we only use it as root irq controller.
> +
> + - csky,apb-intc is used in a lot of csky fpgas and socs, it support 64 irq nums.
> + - csky,dual-apb-intc consists of 2 apb-intc and 128 irq nums supported.

Can't this be described in DT as 2 csky,apb-intc nodes?

> + - csky,gx6605s-intc is gx6605s soc internal irq interrupt controller, 64 irq nums.
> +
> +=============================
> +intc node bindings definition
> +=============================
> +
> + Description: Describes APB interrupt controller
> +
> + PROPERTIES
> +
> + - compatible
> + Usage: required
> + Value type: <string>
> + Definition: must be "csky,apb-intc"
> + "csky,dual-apb-intc"
> + "csky,gx6605s-intc"
> + - interrupt-cells

#interrupt-cells

> + Usage: required
> + Value type: <u32>
> + Definition: must be <1>

No edge or level configuration?

> + - reg
> + Usage: required
> + Value type: <u32 u32>
> + Definition: <phyaddr size> in soc from cpu view
> + - interrupt-controller:
> + Usage: required
> +
> +Examples:
> +---------
> +
> + intc: interrupt-controller {

Needs a unit-address.

> + compatible = "csky,apb-intc";
> + #interrupt-cells = <1>;
> + reg = <0x00500000 0x400>;
> + interrupt-controller;
> + };
> --
> 2.7.4
>