Re: [PATCH v3] proc/kcore: fix invalid memory access in multi-page read optimization

From: Dominique Martinet
Date: Wed Sep 05 2018 - 18:01:07 EST


Andrew Morton wrote on Wed, Sep 05, 2018:
> lgtm. Let's add a nice little why-were-doing-this?

Sure, thank you.

> --- a/fs/proc/kcore.c~proc-kcore-fix-invalid-memory-access-in-multi-page-read-optimization-v3-fix
> +++ a/fs/proc/kcore.c
> @@ -464,7 +464,7 @@ read_kcore(struct file *file, char __use
> ret = -EFAULT;
> goto out;
> }
> - m = NULL;
> + m = NULL; /* skip the list anchor */
> } else if (m->type == KCORE_VMALLOC) {
> vread(buf, (char *)start, tsz);
> /* we have to zero-fill user buffer even if no read */

--
Dominique