Re: [PATCH v13 04/13] x86/sgx: Architectural structures

From: Jarkko Sakkinen
Date: Wed Sep 05 2018 - 13:32:55 EST


On Tue, Sep 04, 2018 at 09:04:44AM -0700, Dave Hansen wrote:
> On 09/03/2018 06:16 AM, Andy Shevchenko wrote:
> >> + EBLOCK = 0x9,
> >> + EPA = 0xA,
> >> + EWB = 0xB,
> >> + ETRACK = 0xC,
> >> + EAUG = 0xD,
> >> + EMODPR = 0xE,
> >> + EMODT = 0xF,
> >> +};
> > Hmm... This E prefix confuses me with (system wide) error codes. Has
> > it been discussed before? If so, can you point on the conclusion why
> > the current format is good?
>
> Making them SGX_EWHATEVER isn't a horrible idea.

OK, going with that.

/Jarkko