Re: [PATCH v2] libnvdimm, region_devs: stop NDD_ALIASING bit test if one test pass

From: Dan Williams
Date: Tue Sep 04 2018 - 11:57:50 EST


On Tue, Sep 4, 2018 at 3:47 AM, Ocean He <oceanhehy@xxxxxxxxx> wrote:
> From: Ocean He <hehy1@xxxxxxxxxx>
>
> There is no need to finish entire loop to execute NDD_ALIASING bit test
> against every nvdimm->flags.

Of course there is. I see nothing stopping someone mixing an NVDIMM
that supports labels with one that doesn't. If anything I think we
need fixes to make sure this operates correctly to force disable
BLK-mode capactiy when the PMEM capacity is interleaved with a
label-less NVDIMM.