Re: [PATCH v2 15/34] ARM: tegra: apalis_t30: reorder backlight properties

From: Daniel Thompson
Date: Mon Sep 03 2018 - 05:22:35 EST


On Fri, Aug 31, 2018 at 06:37:57PM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
>
> Reorder backlight properties.

This is a bit terse. Should the header explain why too?


>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
>
> ---
>
> Changes in v2: None
>
> arch/arm/boot/dts/tegra30-apalis-eval.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis-eval.dts b/arch/arm/boot/dts/tegra30-apalis-eval.dts
> index 9f2392a05532..300ce726ff4d 100644
> --- a/arch/arm/boot/dts/tegra30-apalis-eval.dts
> +++ b/arch/arm/boot/dts/tegra30-apalis-eval.dts
> @@ -185,13 +185,12 @@
>
> backlight: backlight {
> compatible = "pwm-backlight";
> - /* PWM_BKL1 */
> - pwms = <&pwm 0 5000000>;
> brightness-levels = <255 231 223 207 191 159 127 0>;
> default-brightness-level = <6>;
> /* BKL1_ON */
> enable-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
> power-supply = <&reg_3v3>;
> + pwms = <&pwm 0 5000000>; /* BKL1_PWM */
> };
>
> gpio-keys {
> --
> 2.14.4
>