Re: Make perf script easier to use for itrace

From: Jiri Olsa
Date: Mon Sep 03 2018 - 03:31:23 EST


On Fri, Aug 31, 2018 at 05:54:53PM -0500, Kim Phillips wrote:
> On Fri, 31 Aug 2018 15:01:56 -0700
> Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>
> > Also available in
> > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git pt/easy-script-2
> >
> > v1: Initial post
> > v2: Address review comments. Minor fixes to descriptions. Now builds everywhere.
>
> OK, I grabbed the pt/easy-script-2 branch (commit 4c69fd388e17), and
> see build failures for a 'make -C perf' build using gcc version 7.3.0
> (Ubuntu 18.04):
>
> builtin-script.c: In function âparse_output_fieldsâ:
> builtin-script.c:2571:22: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].fields &= ~all_output_options[i].field;
> ^~
> builtin-script.c:2571:22: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].fields &= ~all_output_options[i].field;
> ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> builtin-script.c:2574:10: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].user_set = true;
> ~~~~~~^~~
> builtin-script.c:2575:10: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].wildcard_set = true;
> ~~~~~~^~~
> ...
> util/cs-etm.c: In function âcs_etm__process_auxtrace_infoâ:
> util/cs-etm.c:1436:14: error: âstruct perf_sessionâ has no member named âitrace_synthâ; did you mean âitrace_synth_optsâ?
> session->itrace_synth.default_no_sample);
> ^~~~~~~~~~~~
> itrace_synth_opts

I think Andi has the new changes in pt/easy-script-3 branch,
just did not update the changelog

jirka