RE: [PATCH V2 2/6] x86/efi: Remove __init attribute from memory mapping functions

From: Prakhya, Sai Praneeth
Date: Mon Sep 03 2018 - 01:08:20 EST


> On Sun, Sep 02, 2018 at 02:46:30AM -0700, Sai Praneeth Prakhya wrote:
> > In order to not keep these functions needlessly when
> > "CONFIG_EFI_WARN_ON_ILLEGAL_ACCESS" is not selected, add a new
> > __efi_init_fixup attribute whose value changes based on whether the
>
> Why not just __efi_init{,data} ?

Hmm.. thought that __efi_init might be confusing with the normal __init attribute
and hence added "fixup", so that it's explicit that we are trying to fixup the normal
__init attribute. __efi_init_data doesn't seem appropriate because we are fixing
both functions and data.

Regards,
Sai