Re: [PATCH] scripts: unifdef: fix stringop-truncation warning

From: Tony Finch
Date: Thu Aug 23 2018 - 07:42:42 EST


Harshit Jain <harshitjain6751@xxxxxxxxx> wrote:

> Hey! tony thanks for reviewing, pardon me i wasn't able to get your context
> can you please elaborate a little what you are trying to say?

There's a big block comment above the state machine code which tries to
explain what the blazes is going on. The comment includes an explanation
of the weird strncpy() call, which you need to update to talk about
memcpy() instead.

(The code is heavily compactified because I wrote it on a laptop with a
small screen and I needed to be able to see it all to understand it!)

Tony.
--
f.anthony.n.finch <dot@xxxxxxxx> http://dotat.at/
South Fitzroy: Northerly or northeasterly 5 or 6. Slight or moderate.
Occasional drizzle. Good, occasionally poor at first.