Re: [Skiboot] [PATCH] opal/hmi: Wakeup the cpu before reading core_fir

From: Vaibhav Jain
Date: Thu Aug 23 2018 - 07:33:07 EST


Thanks for reviewing this patch Nick

Nicholas Piggin <npiggin@xxxxxxxxx> writes:
>
> Would it be feasible to enumerate the ranges of scoms that require
> special wakeup and check for those in xscom_read/write, and warn if
> spwkup was not set?
>
I think that might be racy (Vaidy please correct if I am wrong) as a
core can change its state when we read its sleep state and when we do
the actual xscom to read the core_fir.

--
Vaibhav Jain <vaibhav@xxxxxxxxxxxxxxxxxx>
Linux Technology Center, IBM India Pvt. Ltd.