Re: [PATCH] tipc: fix issue that tipc_dest neglects of big-endian

From: Xue, Ying
Date: Tue Aug 21 2018 - 05:57:37 EST


Sorry, I am on vacation too. I agree with Jon. Please temporarily hold this patch. Once I am back, I will review it as soon as possible.

Sent from my iPhone

> On Aug 21, 2018, at 9:52 PM, Jon Maloy <jon.maloy@xxxxxxxxxxxx> wrote:
>
> Hi David,
> Please hold this one for now.
>
> ///jon
>
>> -----Original Message-----
>> From: David Miller <davem@xxxxxxxxxxxxx>
>> Sent: Monday, 20 August, 2018 22:21
>> To: Haiqing.Bai@xxxxxxxxxxxxx
>> Cc: Jon Maloy <jon.maloy@xxxxxxxxxxxx>; ying.xue@xxxxxxxxxxxxx; zhenbo.gao@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH] tipc: fix issue that tipc_dest neglects of big-endian
>>
>> From: Haiqing Bai <Haiqing.Bai@xxxxxxxxxxxxx>
>> Date: Mon, 20 Aug 2018 18:26:01 +0800
>>
>>> The tipc multicast demo in tipcutils fails to work on big-endian hardware.
>>> The tipc multicast server can not receive the packets sent by the multicast
>>> client for that the dest port is always zero after tipc_dest_pop, then it
>>> is found that the struct tipc_dest fails to take big/little endian into
>>> account.
>>>
>>> Signed-off-by: Haiqing Bai <Haiqing.Bai@xxxxxxxxxxxxx>
>>> Signed-off-by: Zhenbo Gao <zhenbo.gao@xxxxxxxxxxxxx>
>>
>> Jon and Ying, please review.
>>
>> thank you.