Re: [PATCH] Raise the minimum required gcc version to 4.6

From: Joe Perches
Date: Mon Aug 20 2018 - 16:48:24 EST


On Mon, 2018-08-20 at 14:42 -0600, Jonathan Corbet wrote:
> On Mon, 20 Aug 2018 13:15:26 -0700
> Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> > +#if GCC_VERSION < 40600
> > +# error Sorry, your compiler is too old - please upgrade it.
> > +#endif
>
> It seems we could be a little friendlier here? "Kernel compilation
> requires GCC >= v4.6, please upgrade" ?

This is unchanged text, it's just moved around, but sure, trivial...

Wordsmithing should likely be a separate patch though.
---
include/linux/compiler-gcc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 250b9b7cfd60..5d95cabd13b3 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -11,7 +11,7 @@
+ __GNUC_PATCHLEVEL__)

#if GCC_VERSION < 40600
-# error Sorry, your compiler is too old - please upgrade it.
+# error Kernel compilation requires GCC >= v4.6, please upgrade your compiler
#endif

/* Optimization barrier */