Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

From: Dave Young
Date: Thu Aug 16 2018 - 04:03:53 EST


On 08/16/18 at 09:43am, Yannik Sembritzki wrote:
> On 16.08.2018 03:11, Dave Young wrote:
> > Instead of fix your 1st patch in 2nd patch, I would suggest to
> > switch the patch order. In 1st patch change the common code to use
> > the new macro and in 2nd patch you can directly fix the kexec code
> > with TRUST_SECONDARY_KEYRING.
> My reasoning for doing it in this order was that the first patch which
> fixes the bug itself should be merged into stable, while the refactoring
> doesn't necessarily have to. I'm not familiar with the linux development
> process, so please correct me if this should be done in another fashion.

Frankly I'm not sure about the stable process. But personally I do not
like the order.

Cced Greg for opinions about stable concern.

>
> Yannik