Re: [PATCH] RDMA/bnxt_re: QPLIB: Add and use #define dev_fmt(fmt) "QPLIB: " fmt

From: Jason Gunthorpe
Date: Wed Aug 15 2018 - 17:10:59 EST


On Fri, Aug 10, 2018 at 11:42:46AM -0700, Joe Perches wrote:
> Consistently use the "QPLIB: " prefix for dev_<level> logging.
>
> Miscellanea:
>
> o Add missing newlines to avoid possible message interleaving
> o Coalesce consecutive dev_<level> uses that emit a message header to
> avoid < 80 column lengths and mistakenly output on multiple lines
> o Reflow modified lines to use 80 columns where appropriate
> o Consistently use "%s: " where __func__ is output
> o QPLIB: is now always output immediately after the dev_<level> header
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 130 +++++++++++------------------
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 51 ++++++-----
> drivers/infiniband/hw/bnxt_re/qplib_res.c | 29 ++++---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 57 ++++++-------
> 4 files changed, 116 insertions(+), 151 deletions(-)

Broadcom: This is a big patch, will you ack it please?

https://patchwork.kernel.org/patch/10563083/

Thanks,
Jason