Re: [PATCH] EDAC: i82443bxgx: Fix invalid memory type assignment

From: Takashi Iwai
Date: Wed Aug 15 2018 - 12:01:33 EST


On Wed, 15 Aug 2018 17:57:52 +0200,
Borislav Petkov wrote:
>
> On Fri, Aug 10, 2018 at 04:15:20PM +0200, Takashi Iwai wrote:
> > The i82443bxgx_edac driver assigns an invalid negative value when an
> > unknown DRAM type is detected. Drop the unnecessary '-' that brings
> > misbehavior.
> >
> > Fixes: 5a2c675c8919 ("drivers/edac: new i82443bxgz MC driver")
> > Cc: <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > ---
> > drivers/edac/i82443bxgx_edac.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
> > index a2ca929e2168..1638f288fa47 100644
> > --- a/drivers/edac/i82443bxgx_edac.c
> > +++ b/drivers/edac/i82443bxgx_edac.c
> > @@ -273,7 +273,7 @@ static int i82443bxgx_edacmc_probe1(struct pci_dev *pdev, int dev_idx)
> > break;
> > default:
> > edac_dbg(0, "Unknown/reserved DRAM type value in DRAMC register!\n");
> > - mtype = -MEM_UNKNOWN;
> > + mtype = MEM_UNKNOWN;
> > }
> >
> > if ((mtype == MEM_SDR) || (mtype == MEM_RDR))
> > --
>
> Is this something you caught by inspection or you really have hw that
> loads that driver...

I just followed the old percept: read the source, Luke.

> Wikipedia says 440BX chipset is pentium II and III which, if so, would
> drop its priority considerably. CC:stable would be not needed either, TBH.

OK, feel free to drop that.


thanks,

Takashi